Comments you submit will be routed for moderation. If you have an account, please log in first.

Ticket #421 (new enhancement)

Opened 13 months ago

Allow modules to be symlinked from elsewhere

Reported by: nwfilardo@… Owned by:
Priority: trivial Milestone:
Component: LuCI Base Keywords:
Cc:

Description

The default instructions for writing modules say to reference config.mk and module.mk by relative paths; unfortunately, this does not work when symbolic links are used to bring modules in to the tree from elsewhere.

I propose the following patch, which grabs the build/ directory into an exported variable BUILDPATH, allowing modules to write the location-insensitive

 include $(BUILDPATH)config.mk
 include $(BUILDPATH)module.mk

Index: Makefile
===================================================================
--- Makefile	(revision 8690)
+++ Makefile	(working copy)
@@ -1,3 +1,6 @@
+BUILDPATH=$(dir $(abspath $(lastword $(MAKEFILE_LIST))))
+export BUILDPATH
+
 include build/config.mk
 
 MODULES = contrib/* applications/* libs/* modules/* themes/* i18n/*

Attachments

Add/Change #421 (Allow modules to be symlinked from elsewhere)

Author


E-mail address and user name can be saved in the Preferences.


Action
as new
 
Note: See TracTickets for help on using tickets.