Assert error in /usr/lib/lua/luci/controller/luci_diag/devinfo_common.lua

[hnyman]

Since July 24th, my Openwrt trunk builds lock me totally out of the Luci GUI. The browser session gets stuck to an assert error before password prompt in Luci.

/usr/lib/lua/luci/dispatcher.lua:492: Invalid controller file found
The file '/usr/lib/lua/luci/controller/luci_diag/devinfo_common.lua' contains no index() function.
Please make sure that the controller contains a valid index function and verify the spelling!
stack traceback:
	[C]: in function 'assert'
	/usr/lib/lua/luci/dispatcher.lua:492: in function 'createindex_plain'
	/usr/lib/lua/luci/dispatcher.lua:420: in function 'createindex'
	/usr/lib/lua/luci/dispatcher.lua:512: in function 'createtree'
	/usr/lib/lua/luci/dispatcher.lua:182: in function 'dispatch'
	/usr/lib/lua/luci/dispatcher.lua:146: in function </usr/lib/lua/luci/dispatcher.lua:145>

Only console works.

That assertion error message seems to have been recently introduced with Luci r7325 . (Previous trunk build from July 19th works ok)

Openwrt built with dirclean, whole Luci source re-pulled with SVN from server. Flash without settings, so it should be a clean slate.

I can't verify if this is something special to my build, or has the new assertion error revealed some old flaw in Luci source. The referenced file, devinfo_common.lua ( http://luci.subsignal.org/trac/browser/luci/trunk/applications/luci-diag-devinfo/luasrc/controller/luci_diag/devinfo_common.lua ), is rather old, so either this new assertion just brings something out, or there is something wrong with my WNDR3700 build...

My Backfire build with Luci 0.10 works just normally.

(This ticket might be a double. I thought that I filed this yesterday, but so far it has not surfaces through the moderation queue.)

[hnyman]

I tested building without luci-app-diag-devinfo package.
The build works normally, so that package is the faulty one.

[luci@…]

I can confirm this for r7335

[jow]

Fixed with r7336, r7337