Comments you submit will be routed for moderation. If you have an account, please log in first.

Ticket #264 (new defect)

Opened 23 months ago

Last modified 23 months ago

I find 3 issues that should be fixed

Reported by: Tian HP Owned by:
Priority: major Milestone: LuCI 0.10.0
Component: LuCI Applications Keywords:
Cc:

Description

I find 3 issues that I think should be fixed:
Issue 1.
On different pages, the word Destination and the word Target stands for the same meaning, but in different languages they have different meaning, which may confuse the end users.

The pages:
Status->Routes
network->Routes->Static Routes
Status->Firewall

The corresponding files:
modules/admin-full/luasrc/view/admin_status/routes.htm
modules/admin-full/luasrc/model/cbi/admin_network/routes.lua
modules/admin-full/luasrc/view/admin_status/connections.htm
applications/luci-firewall/luasrc/model/cbi/luci_fw/zones.lua

Issue 2.
The word Interface, Network and Zone have different meanings, but they are not strictly differentiated.

The pages:
Network->Interfaces
Network->Firewall
Status->Routes

The corresponding files:
modules/admin-full/luasrc/view/admin_network/iface_overview.htm
applications/luci-firewall/luasrc/model/cbi/luci_fw/zones.lua
modules/admin-full/luasrc/view/admin_status/routes.htm

lan includes lan wlan br-lan; wan includes wan wwan and maybe 3g interface.

Issue 3.
There are many functions named update_status(). When different update_status encounters with one another, for example on the page Status, the browser is confused, which will call nothing.

The files including update_status().
modules/admin-full/luasrc/view/admin_network/iface_overview.htm
modules/admin-full/luasrc/view/admin_network/wifi_status.htm
modules/admin-full/luasrc/view/admin_network/wifi_overview.htm
modules/admin-full/luasrc/view/admin_network/diagnostics.htm
modules/admin-full/luasrc/view/admin_network/lease_status.htm
modules/admin-full/luasrc/view/admin_network/iface_status.htm
modules/admin-full/luasrc/view/admin_status/index.htm
applications/luci-upnp/luasrc/view/upnp_status.htm
applications/luci-ahcp/luasrc/view/ahcp_status.htm

Attachments

Change History

Changed 23 months ago by jow

Regarding point 3: those files are never included together. If a browser confuses functions with the same name in different scripts on different pages then something is wrong with the browser.

Changed 23 months ago by jow

In the case of upnp_ and ahcp_status thats not even a function name but an anonymous function stored in a local variable, thats a big difference.

Add/Change #264 (I find 3 issues that should be fixed)

Author


E-mail address and user name can be saved in the Preferences.


Action
as new
 
Note: See TracTickets for help on using tickets.