[svn6982] No language display in App openVPN

[mrk]

LuCI Trunk 0.10+svn6982

In application openVPN is an error in displaying the language specific texts. I test it with en and de.

See also screenshot.

[anonymous]

Screenshot

[soma]

You have found a bug here that existed for 3 years now. It seems there is not much interest in the openvpn app given nobody else noticed in all that time (or at least didn't care enough to create a ticket). I talked to jow and we agreed that the openvpn-app as a whole is of questionable use, because it would be much faster (and easier) to do all that on the console (C&P config, keys, done). A rewrite which is more like a wizard would probably be a good idea, but i can't say when of even if that will happen.

I tested a bit around with the translation and there would be an quite easy fix for the problem you described, but it would involve copy and paste all strings (and there are a lot, i guess maybe 40-50) from the translation base file to the app-openvpn files.

If you or something else is willing to do that: i attached a patch that extends the table in the beginning of openvpn-basics.lua. The same should be done for openvpn-advanced.lua then, too. It adds a fourth column in the table with the description and changes the parameter name to its real name like it is shown in the openvpn.config. See attached screenshot.

[soma]

example patch for i18n for openvpn

[soma]

Screenshot with the patch applied

[pierre.gaufillet@…]

Hi!

I just uploaded a preliminary fix to this defect. Please tell me if this patch is ok on the principle so that I can if required correct it and then go further.

[soma]

Hi Pierre

your patch looks good. I see you also used the translations which are already there, excellent :)

[pierre.gaufillet@…]

i18n using openvpn.pot strings

[pierre.gaufillet@…]

Hi guys!

I uploaded a quite complete patch dealing with openvpn i18n. Some work to do remains, through:

- translating advanced configuration titles (I am not able to fix the lua/html code as required: some help is required there),
- regenerate pot / po files (not done because it impacts all translations, but it is needed as a few descriptions are unused or buggy, and of course bout 10 newly introduced translations are missing),
- review the english descriptions as some of them are not clearly extracted from the openvpn manual.

But it will be easier to work on these topics with updated files on svn.

I hope this (quite boring) job will be useful ;)

[soma]

Thanks, i committed this in trunk with r7612. I'm not sure what you mean with "translating advanced configuration titles", can you elaborate on that a bit more?

[pierre.gaufillet@…]

Sorry to be unclear...

If you switch openvpn pages to advanced mode and to a section like vpn, you will see that the title of the section is not translated and still seems to follow the old _desc naming convention. I don't know how to fix that but it should be done.

[soma]

I fixed this with r7719. Please let me know when you are done with the other stuff, i will merge this back to luci-0.10 then.

[pierre.gaufillet@…]

Thanks!

It should take me still a few days to review english descriptions vs openvpn manual.

It seems also that something goes wrong with the VPN advanced section: this is the only page where descriptions of parameters don't appear. Could you please have a look to it?

[pierre.gaufillet@…]

Fix about VPN parameters issue uploaded. It was caused by the declaration of dependencies between parameters in wrong columns.

[soma]

I applied that patch in r7774, but there is still a problem: depends don't work as they should because they will only work if the option it depends on are on the same page.

[pierre.gaufillet@…]

Proposal with Taboptions

[pierre.gaufillet@…]

Hello soma!

To solve the dependency issue you have discovered, I propose a new form designed with tab sections/options.

Note that I did not find how the visilibity of options was decided with classical / tab options. The "Additional fields" widget seems to appear automagically for classical sections, and never for tab sections.

[soma]

Hi,

yes, i also think tabs would be good and experimented a bit with these. But it is not possible to use "Additional fields" when using tabs. That means a lot of options will be displayed on every tab which is also not optimal. Stuill, it would solve the depency issues.

[pierre.gaufillet@…]

Why not modifying tabs to support additional fields?

[pierre.gaufillet@…]

Hi!

I suggest closing this bug report as advanced tab i18n now works and create a new one to track the remaining dependencies issue.

Btw, I am currently trying to add optional/additional fields concept to tabs to solve that.

[soma]

ok, done, feel free to create a new one for the outstanding issues.