Ticket #203 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Modifying LED configuration brakes USB LED

Reported by: ferob Owned by:
Priority: major Milestone: LuCI 0.10.0
Component: LuCI Base Keywords: modify led configuration
Cc:

Description

Any modification made in LED configuration tab brakes USB LED.

It removes

option 'dev' '1-1'

and adds

option 'default' '0'

line to the usb_led config.

Before:

config 'led' 'usb_led'
        option 'sysfs' 'wndr3700:green:usb'
        option 'name' 'USB LED (green)'
        option 'trigger' 'usbdev'
        option 'interval' '50'
        option 'dev' '1-1'

After:

config 'led' 'usb_led'
        option 'sysfs' 'wndr3700:green:usb'
        option 'name' 'USB LED (green)'
        option 'trigger' 'usbdev'
        option 'interval' '50'
        option 'default' '0'

Change History

  Changed 4 years ago by hannu.nyman@…

Looks like you are right. I guess this affects all ar71xx based devices, to whose profiles the usbdev device has been added.

I tested my WNDR3700 with Trunk build r 25662 (with up-to-date Luci trunk), and even changing the first LED's default status causes the other LED to lose the 'dev' parameter. I do understand the other changes below (intended switch of default value, and then the automatic adding a missing trigger and the missing default value for the other LED), but the destroyed 'dev' value is an error.

Changes caused:

root@OpenWrt:/etc/config# diff system.bak system
--- system.bak
+++ system
@@ -10,12 +10,13 @@
 config 'led' 'wan_led'
        option 'sysfs' 'wndr3700:green:wan'
        option 'name' 'WAN LED (green)'
-       option 'default' '0'
+       option 'default' '1'
+       option 'trigger' 'none'

 config 'led' 'usb_led'
        option 'name' 'USB'
        option 'sysfs' 'wndr3700:green:usb'
        option 'trigger' 'usbdev'
-       option 'dev' '1-1'
        option 'interval' '50'
+       option 'default' '0'

Context for the device and parameters, added in December in r 24647 and 24648:
 https://dev.openwrt.org/changeset/24647 (basic support)
 https://dev.openwrt.org/changeset/24648 (devices, configs)
 https://dev.openwrt.org/changeset/24940 (including usbdev module by default)

Luci should probably be modified to at least preserve that option.

follow-up: ↓ 3   Changed 4 years ago by anonymous

Are you guys' usb led flickering or just constantly on when RWing?

in reply to: ↑ 2   Changed 4 years ago by anonymous

Replying to anonymous:

Are you guys' usb led flickering or just constantly on when RWing?

Flickering on Trunk during RW, when the config is right.
Constantly on on Backfire when connected, as there is no proper usb trigger

  Changed 3 years ago by jow

  • status changed from new to closed
  • resolution set to fixed

Should be fixed in recent versions

Note: See TracTickets for help on using tickets.